terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

node_pool specific labels

Open arvin-pjr opened this issue 3 years ago • 2 comments

currently we can only set labels for all node_pools but not possible on individual node pool which make the nodeSelection hard from workload point of view.

arvin-pjr avatar Oct 17 '22 15:10 arvin-pjr

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 17 '22 15:10 google-cla[bot]

will open fresh

arvin-pjr avatar Oct 18 '22 02:10 arvin-pjr

@arvin-pjr Thanks for the PR! 🚀 Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

  • ⚠️check_generate_modules The modules need to be regenerated. Please run make_build.
Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster/cluster.tf /tmp/tmp.M6lrKuOeoW/workspace/modules/private-cluster/cluster.tf
377d376
<       lookup(each.value, "labels", {}),
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

comment-bot-dev avatar Oct 18 '22 02:10 comment-bot-dev