terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

fix: expose global master access in GA modules

Open ericyz opened this issue 3 years ago • 1 comments

The Global Master Access is already in GA TF provider.

This change will expose private_cluster_config.master_global_access_config in available GA modules

ericyz avatar Oct 07 '22 05:10 ericyz

Updated. @bharathkkb - please review

ericyz avatar Oct 27 '22 05:10 ericyz

@ericyz Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Oct 27 '22 05:10 comment-bot-dev

@bharathkkb - I think the test case was failed due to other reasons. Could you please help to verify and let me know any chance required for this MR

ericyz avatar Nov 01 '22 04:11 ericyz

Hi @bharathkkb , any chance to review and provide feedback? This MR is on the critical path on the project. (rebased to master)

ericyz avatar Nov 14 '22 22:11 ericyz

@ericyz Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Nov 17 '22 01:11 comment-bot-dev

Does this change Global master access default to True

gamepop avatar Feb 01 '23 22:02 gamepop