terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

Published 20 hours ago • verified publisher icon terraform-google-modules

feat: update default value to enable private ip

Open ericyz opened this issue 3 years ago • 5 comments

ericyz avatar Sep 07 '22 07:09 ericyz

@ericyz Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Sep 07 '22 07:09 comment-bot-dev

As it aims to create private cluster, default to enable_private_nodes = true would make more logical sense.

ericyz avatar Sep 19 '22 11:09 ericyz

I also acknowledge that it is a breaking change. Would you consider to incorporate it into next major version bump?

ericyz avatar Sep 19 '22 11:09 ericyz

@ericyz considering we have safer cluster and this is exposed via a variable, I am leaning towards not making this breaking change change.

bharathkkb avatar Sep 20 '22 03:09 bharathkkb

I am for minimising the disruption, but having a public cluster with default value deviated the name of the private module. Hope this can get considered in future breaking change.

ericyz avatar Oct 07 '22 05:10 ericyz

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Dec 06 '22 23:12 github-actions[bot]