terraform-google-container-vm icon indicating copy to clipboard operation
terraform-google-container-vm copied to clipboard

Published 20 hours ago • verified publisher icon terraform-google-modules

use random_password instead of random_id for secrets

Open mikecook opened this issue 2 years ago • 6 comments

  • random_id byte_length = 8 (integers) contains 26.6 bits of entropy. base64 encoding does not change that entropy. Instead use random_password length = 32 restricted to (upper, lower, int) which contains 190.5 bits of entropy.
  • Restrict random_password to special = false to prevent issues with allowed characters.

mikecook avatar Apr 26 '22 20:04 mikecook

Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Apr 26 '22 20:04 comment-bot-dev

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Jun 25 '22 23:06 github-actions[bot]

Would someone review this please?

mikecook avatar Jul 04 '22 00:07 mikecook

@morgante ?

mikecook avatar Jul 06 '22 21:07 mikecook

/gcbrun

apeabody avatar Jul 20 '22 16:07 apeabody

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Sep 18 '22 23:09 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Nov 18 '22 23:11 github-actions[bot]