terraform-google-cloud-storage icon indicating copy to clipboard operation
terraform-google-cloud-storage copied to clipboard

Hmac access feature

Open vkamlov opened this issue 3 years ago • 4 comments

Hi there! In this PR I would like to add the possibility of granting HMAC access to service accounts. This will be useful for people, who want to create access to buckets using access keys and secret keys. If you see what can be better here, feel free to add your changes

vkamlov avatar Aug 03 '22 18:08 vkamlov

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 03 '22 18:08 google-cla[bot]

Changed author and committer info, for passing CLA

vkamlov avatar Aug 03 '22 18:08 vkamlov

Can someone check this PR? There aren't a lot of changes, only adding a little functionality

vkamlov avatar Sep 13 '22 14:09 vkamlov

@vkamlov Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Oct 28 '22 19:10 comment-bot-dev

@bharathkkb could you review it again?

vkamlov avatar Jan 19 '23 15:01 vkamlov

@vkamlov Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Jan 26 '23 10:01 comment-bot-dev

Why do the int and lint checks don't execute?

vkamlov avatar Mar 21 '23 14:03 vkamlov

/gcbrun

apeabody avatar Mar 21 '23 15:03 apeabody

Why do the int and lint checks don't execute?

Thanks for the contribution @vkamlov. A maintainer needs to trigger the CI, which I just did for the most recent commit.

apeabody avatar Mar 21 '23 15:03 apeabody

/gcbrun

apeabody avatar Mar 21 '23 16:03 apeabody

Thanks! Can you merge my changes if everything will be ok?

vkamlov avatar Mar 21 '23 16:03 vkamlov

Thanks! Can you merge my changes if everything will be ok?

Looks good, done!

apeabody avatar Mar 21 '23 16:03 apeabody

A lot of thanks!

vkamlov avatar Mar 21 '23 16:03 vkamlov