terraform-google-cloud-storage
terraform-google-cloud-storage copied to clipboard
Hmac access feature
Hi there! In this PR I would like to add the possibility of granting HMAC access to service accounts. This will be useful for people, who want to create access to buckets using access keys and secret keys. If you see what can be better here, feel free to add your changes
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Changed author and committer info, for passing CLA
Can someone check this PR? There aren't a lot of changes, only adding a little functionality
@vkamlov
Thanks for the PR! 🚀
✅ Lint checks have passed.
@bharathkkb could you review it again?
@vkamlov
Thanks for the PR! 🚀
✅ Lint checks have passed.
Why do the int and lint checks don't execute?
/gcbrun
Why do the int and lint checks don't execute?
Thanks for the contribution @vkamlov. A maintainer needs to trigger the CI, which I just did for the most recent commit.
/gcbrun
Thanks! Can you merge my changes if everything will be ok?
Thanks! Can you merge my changes if everything will be ok?
Looks good, done!
A lot of thanks!