terraform-google-cloud-storage icon indicating copy to clipboard operation
terraform-google-cloud-storage copied to clipboard

Adds cft.json to .gitignore

Open joaovitor opened this issue 3 years ago • 5 comments

The cft.json created in this codelab is being commited by mistake in some prs. This can generate leak and bad usage.

Adding cft.json go .gitignore can avoid versioning files that should not be versioned.

https://codelabs.developers.google.com/cft-onboarding?hl=en#3

joaovitor avatar May 26 '22 01:05 joaovitor

https://github.com/terraform-google-modules/terraform-google-cloud-storage/pull/172

https://github.com/terraform-google-modules/terraform-google-cloud-storage/pull/71/

joaovitor avatar May 26 '22 01:05 joaovitor

@kunalkg11 can you please review this PR?

joaovitor avatar May 26 '22 01:05 joaovitor

/gcbrun

apeabody avatar Jul 13 '22 21:07 apeabody

@joaovitor Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Jul 13 '22 21:07 comment-bot-dev

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Sep 11 '22 23:09 github-actions[bot]

fixed by https://github.com/terraform-google-modules/terraform-google-cloud-storage/pull/199

bharathkkb avatar Nov 11 '22 20:11 bharathkkb