terraform-google-cloud-dns icon indicating copy to clipboard operation
terraform-google-cloud-dns copied to clipboard

feat: Add support to health check

Open aming27 opened this issue 5 months ago • 5 comments

Add health_checked_targets support into wrr block.(https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/dns_record_set.html#health_checked_targets-1)

aming27 avatar Jun 11 '25 09:06 aming27

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 11 '25 09:06 google-cla[bot]

@aming27 I think we should keep the the value of records variable present in the routing policy dynamic block to be optional as well. This way it would let me keep only health-checked targets without any normal rrdatas. Currently It does not let me do that. Otherwise, this patch works perfectly

Devansh-Bhatt avatar Jul 31 '25 09:07 Devansh-Bhatt

@Devansh-Bhatt I've added rrdatas = try(wrr.value.records, []) for making rrdatas optional.

aming27 avatar Jul 31 '25 11:07 aming27

Hi @Devansh-Bhatt please any update ? Thanks!!!

aming27 avatar Sep 01 '25 13:09 aming27

Hi! Any update?

JorTurFer avatar Sep 15 '25 07:09 JorTurFer