terraform-example-foundation icon indicating copy to clipboard operation
terraform-example-foundation copied to clipboard

2 symlinks in 3-n-h-a-s switched from ../../ to ../shared in #1107 nonprod refactor error during #119

Open fmichaelobrien opened this issue 9 months ago • 1 comments

TL;DR

3-networks-hub-and-spoke

  • 2 symlinks modified in error during the non-production to nonproduction rename/refactor - the change is to ../common - which itself is a symlink so the double symlink works. The other 6 of the 2x4 symlinks are unmodified as ../../ see change in #1107 https://github.com/terraform-google-modules/terraform-example-foundation/pull/1107/files#diff-bcfdfb477dea3f75d9d515aa61ce4f3836b223f11d6e4234122778963fbfef4a

https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/nonproduction/access_context.auto.tfvars

-../../access_context.auto.tfvars
+../shared/access_context.auto.tfvars

there is a 2nd symlink regression in the same directory in https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/nonproduction/common.auto.tfvars

-../../common.auto.tfvars
+../shared/common.auto.tfvars

I'll raise an issue shortly with the fix after I test a full upstream sync of the TEF.

Screenshot 2024-05-11 at 19 09 03

Expected behavior

Symlinks unmodified

Observed behavior

Same behavior but now running double symlinks for 2 of 8

Terraform Configuration

N/a cb/car default

Terraform Version

1.3.10

Additional information

During an upstream sync from TEF master to pbmm master.

I'll put up a patch tonight

fmichaelobrien avatar May 12 '24 14:05 fmichaelobrien