terraform-example-foundation icon indicating copy to clipboard operation
terraform-example-foundation copied to clipboard

Published 20 hours ago • verified publisher icon terraform-google-modules

chore: Fix project labels

Open mariammartins opened this issue 1 year ago • 16 comments

Hello folks,

This PR contains:

  • changes in environment and env_code project labels

  • change the variable from vpc_type to vpc

  • Adding the use of the string "nul" in the vpc variable when the projects does not have a network

mariammartins avatar Feb 06 '24 18:02 mariammartins

/gcbrun

Samir-Cit avatar Feb 07 '24 17:02 Samir-Cit

/gcbrun

mariammartins avatar Feb 07 '24 18:02 mariammartins

/gcbrun

romanini-ciandt avatar Feb 07 '24 18:02 romanini-ciandt

/gcbrun

apeabody avatar Feb 08 '24 15:02 apeabody

/gcbrun

romanini-ciandt avatar Feb 08 '24 19:02 romanini-ciandt

re-triggered HubAndSpoke (default already passed)

apeabody avatar Feb 09 '24 01:02 apeabody

/gcbrun

renato-rudnicki avatar Feb 14 '24 20:02 renato-rudnicki

/gcbrun

romanini-ciandt avatar Feb 15 '24 19:02 romanini-ciandt

/gcbrun

Samir-Cit avatar Feb 16 '24 14:02 Samir-Cit

/gcbrun

renato-rudnicki avatar Feb 23 '24 13:02 renato-rudnicki

/gcbrun

Samir-Cit avatar Feb 23 '24 17:02 Samir-Cit

/gcbrun

Samir-Cit avatar Feb 24 '24 22:02 Samir-Cit

/gcbrun

Samir-Cit avatar Feb 27 '24 19:02 Samir-Cit

/gcbrun

Samir-Cit avatar Mar 04 '24 18:03 Samir-Cit

/gcbrun

Samir-Cit avatar Mar 12 '24 17:03 Samir-Cit

/gcbrun

apeabody avatar Mar 18 '24 20:03 apeabody

/gcbrun

romanini-ciandt avatar Mar 28 '24 12:03 romanini-ciandt

/gcbrun

Samir-Cit avatar Mar 28 '24 14:03 Samir-Cit

/gcbrun

romanini-ciandt avatar Mar 28 '24 15:03 romanini-ciandt

/gcbrun

romanini-ciandt avatar Apr 03 '24 12:04 romanini-ciandt

/gcbrun

daniel-cit avatar Apr 04 '24 00:04 daniel-cit

/gcbrun

daniel-cit avatar Apr 04 '24 03:04 daniel-cit

/gcbrun

daniel-cit avatar Apr 04 '24 18:04 daniel-cit

/gcbrun

daniel-cit avatar Apr 04 '24 22:04 daniel-cit

/gcbrun

romanini-ciandt avatar Apr 05 '24 13:04 romanini-ciandt

  • 2 symlinks modified in error during the non-production to nonproduction rename/refactor - the change is to ../common - which itself is a symlink so the double symlink works. The other 6 of the 2x4 symlinks are unmodified as ../../ see change in #1107 https://github.com/terraform-google-modules/terraform-example-foundation/pull/1107/files#diff-bcfdfb477dea3f75d9d515aa61ce4f3836b223f11d6e4234122778963fbfef4a

https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/nonproduction/access_context.auto.tfvars

-../../access_context.auto.tfvars
+../shared/access_context.auto.tfvars

there is a 2nd symlink regression in the same directory in https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/nonproduction/common.auto.tfvars

-../../common.auto.tfvars
+../shared/common.auto.tfvars

I'll raise an issue shortly with the fix after I test a full upstream sync of the TEF.

obriensystems avatar May 11 '24 23:05 obriensystems

See https://github.com/terraform-google-modules/terraform-example-foundation/issues/1229

fmichaelobrien avatar May 12 '24 14:05 fmichaelobrien