terraform-google-modules
fix(cloudrun): delete protection, default service names
Two updates to Cloud Run samples
fix(cloudrun): make delete protection explicit
fixes #730
Adds deletion_protection = false to tested Cloud Run services (which fixes testing, while not adding things that aren't required for untested samples)
fix(cloudrun): update cloud run services names to unique values
fixes #164
Since most Cloud Run service samples are being updated anyway, use named services when useful, otherwise use "my-service" (don't encode product name into product instance name)
Checklist
Readiness
- [ ] Yes, merge this PR after it is approved
- [ ] No, don't merge this PR after it is approved
Style
- [ ] My sample follows the rules described for Terraform in the Effective Samples style guide
- [ ] My sample follows the other requirements and best practices in the Contributing guide
Testing
-
[ ] I have performed tests described in the Contributing guide:
Intended location
-
[ ] Yes, this sample will be (or already is) included on cloud.google.com Location(s):
-
[ ] No, this sample won't be included on cloud.google.com Reason:
API enablement
- [ ] If the sample needs an API enabled to pass testing, I have added the service to the Test setup file
Review
- [ ] If this sample adds a new directory, I have added codeowners to the CODEOWNERS file
