tf_aws_bastion_s3_keys icon indicating copy to clipboard operation
tf_aws_bastion_s3_keys copied to clipboard

Use python3 for Ubuntu 18.04+

Open andrew-cormick-dockery opened this issue 4 years ago • 3 comments

The current user script doesn't work for Ubuntu LTS > 18.04 due to the fact that python3 is now the default python version. I have confirmed that this PR successfully works with Ubuntu 20.04 LTS.

It won't be backwards compatible though, perhaps someone can suggest a way to do that?

andrew-cormick-dockery avatar Nov 23 '20 04:11 andrew-cormick-dockery

Oof. I suddenly realised this PR won't work for RedHat based distros. Anyone care to make a fix?

andrew-cormick-dockery avatar Nov 23 '20 22:11 andrew-cormick-dockery

Should we just leave the RedHat branch of the logic alone for now and update the Ubuntu part?

wilson avatar Jul 15 '22 13:07 wilson

I made a commit for RedHat based distros not long after that comment.

This commit is ready to be merged. We've been using a fork of this repo with this commit in it for almost 2 years now; it works just fine with Ubuntu.

andrew-cormick-dockery avatar Jul 18 '22 01:07 andrew-cormick-dockery