terraform-aws-vpc icon indicating copy to clipboard operation
terraform-aws-vpc copied to clipboard

Published 20 hours ago • verified publisher icon terraform-aws-modules

feat: Optional for public route_table_association

Open gn-jayden-z opened this issue 6 months ago • 2 comments

Description

The current module does not provide an option to disable the creation of public route associations. This PR hopes to include a variable to control that.

Motivation and Context

We create a network firewall outside of this module and associate the existing public subnet with the new firewall routing tables.

However, this introduces drift since we can't disable the association from this module.

We need to set this as optional for the public route association.

Breaking Changes

None as far as I can observe var. create_public_route_association is default to true

How Has This Been Tested?

We tested this internally.

gn-jayden-z avatar May 13 '25 02:05 gn-jayden-z

Hi @antonbabenko could you please to review this PR ? Thanks

vietwow avatar May 26 '25 06:05 vietwow

@antonbabenko @vietwow Any movement on this? This is exactly what we need for the exact same use case (firewall route tables) as the PR author.

springroll12 avatar Jun 13 '25 20:06 springroll12

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Jul 14 '25 00:07 github-actions[bot]

Hi @antonbabenko can we get your help to review this

gn-jayden-z avatar Jul 16 '25 07:07 gn-jayden-z

@antonbabenko @vietwow Any movement on this? This is exactly what we need for the exact same use case (firewall route tables) as the PR author.

still waiting @antonbabenko for reviewing this

vietwow avatar Jul 16 '25 07:07 vietwow

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Aug 17 '25 00:08 github-actions[bot]

Bump @antonbabenko please

gn-jayden-z avatar Aug 17 '25 10:08 gn-jayden-z

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Sep 18 '25 00:09 github-actions[bot]

I'll take a look at the Network Firewall integration options today

bryantbiggs avatar Sep 22 '25 16:09 bryantbiggs

@bryantbiggs Is there any idea of if/when this would get merged? We are deploying an NGFW and without this, we're basically forcing the allowance of drift. Which isn't ideal for obvious reasons, but this is the big thing we need to allow for changing the 0/0 route.

bengaywins avatar Nov 04 '25 18:11 bengaywins

Can we expand this variable to all types of available subnets? . If anyone agrees, let me raise it as another PR with variables for all types of subnets.

Jay-Aiy avatar Nov 14 '25 13:11 Jay-Aiy