terraform-aws-transit-gateway icon indicating copy to clipboard operation
terraform-aws-transit-gateway copied to clipboard

Published 20 hours ago • verified publisher icon terraform-aws-modules

feat: Add support for security group referencing to transit-gateway m…

Open syedimranhassan opened this issue 1 year ago • 6 comments

…odule

Added support for security_group_referencing_support in the transit-gateway module.

Description

Motivation and Context

AWS recently introduced [HERE] security group referencing for Transit Gateway VPC attachments. This feature was available in the standalone resource aws_ec2_transit_gateway_vpc_attachment but not in the transit-gateway module. Added support for it in the module.

Breaking Changes

no

How Has This Been Tested?

  • [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [x] I have tested and validated these changes using one or more of the provided examples/* projects
  • [x] I have executed pre-commit run -a on my pull request

syedimranhassan avatar Sep 27 '24 06:09 syedimranhassan

Would love to see this too! One comment, this new setting exists at the Transit Gateway level too, not just attachments. So the module should also have a new variable for whether to enable it on the TGW. See https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ec2_transit_gateway

jhenry82 avatar Sep 27 '24 15:09 jhenry82

@jhenry82 Thank you for pointing that out. I've updated the code to include SG referencing support at the TGW level as well.

syedimranhassan avatar Sep 28 '24 07:09 syedimranhassan

@jhenry82 Can you please review this?

syedimranhassan avatar Oct 02 '24 16:10 syedimranhassan

I am not a maintainer of this module, my review wouldn't mean much :) I just use the module and came here to see if the feature had been added, and saw your MR. Hopefully it is able to be integrated soon.

jhenry82 avatar Oct 02 '24 18:10 jhenry82

@antonbabenko @bryantbiggs Can you please review this PR?

syedimranhassan avatar Oct 03 '24 10:10 syedimranhassan

We also need this functionality.

fintonic-plaform avatar Oct 21 '24 11:10 fintonic-plaform

BUMP we need this.

tigpt avatar Nov 19 '24 15:11 tigpt

Can we get this feature released?

savealive avatar Dec 12 '24 16:12 savealive

since no activity from the main maintainer, can @syedimranhassan host this fork on terraform registry so I can reference your fork instead of the main project? as a temporary measure. Thanks

tigpt avatar Dec 24 '24 10:12 tigpt

I published it myself to be able to use it, feel free to use until official support.

https://registry.terraform.io/modules/tigpt/transit-gateway/aws/latest

module "tgw" { source = "tigpt/transit-gateway/aws" version = "2.12.4"

... }

All credits go to @syedimranhassan for the work on the PR. Thanks ❤️

tigpt avatar Dec 24 '24 11:12 tigpt

We also need this functionality.

lostsnow avatar Jan 11 '25 09:01 lostsnow

@antonbabenko could you approve this PR please?

savealive avatar Jan 14 '25 23:01 savealive

This PR is included in version 2.13.0 :tada:

antonbabenko avatar Jan 15 '25 19:01 antonbabenko

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Feb 15 '25 02:02 github-actions[bot]