terraform-aws-s3-bucket icon indicating copy to clipboard operation
terraform-aws-s3-bucket copied to clipboard

Published 20 hours ago • verified publisher icon terraform-aws-modules

feat: Add conditionals to delivery policy

Open aiell0 opened this issue 1 year ago • 4 comments

Description

Adds conditionals to the ALB/NLB log delivery policy to help prevent the confused deputy problem.

Motivation and Context

https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/issues/279

Breaking Changes

None

How Has This Been Tested?

  • [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [x] I have tested and validated these changes using one or more of the provided examples/* projects
  • [x] I have executed pre-commit run -a on my pull request

aiell0 avatar Apr 22 '24 02:04 aiell0

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar May 23 '24 00:05 github-actions[bot]

bump

aiell0 avatar May 23 '24 15:05 aiell0

@antonbabenko are we a yay or nay on this?

aiell0 avatar May 24 '24 02:05 aiell0

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Jun 24 '24 00:06 github-actions[bot]

This PR was automatically closed because of stale in 10 days

github-actions[bot] avatar Jul 05 '24 00:07 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Aug 05 '24 02:08 github-actions[bot]