terraform-aws-s3-bucket icon indicating copy to clipboard operation
terraform-aws-s3-bucket copied to clipboard

Published 20 hours ago • verified publisher icon terraform-aws-modules

feat: Add attachable CloudFront OAI and OAC policies

Open gw0 opened this issue 1 year ago • 10 comments

Description

Adds attachable CloudFront Origin Access Identities (deprecated by AWS) and CloudFront Origin Access Identities policies.

Motivation and Context

An AWS S3 bucket is often connected with an AWS CloudFront distribution and configuring a securely authenticated connection should be trivial. Workarounds such as https://github.com/terraform-aws-modules/terraform-aws-cloudfront/blob/master/examples/complete/main.tf#L294-L327 should not be needed.

Breaking Changes

None.

How Has This Been Tested?

  • [ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ ] I have tested and validated these changes using one or more of the provided examples/* projects
  • [ ] I have executed pre-commit run -a on my pull request

gw0 avatar Sep 19 '23 13:09 gw0

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Oct 20 '23 00:10 github-actions[bot]

Is there ay reason why this should not be part of the TF module?

gw0 avatar Oct 20 '23 07:10 gw0

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Nov 20 '23 00:11 github-actions[bot]

.

gw0 avatar Nov 20 '23 10:11 gw0

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Dec 22 '23 00:12 github-actions[bot]

@antonbabenko This TF module already supports off-the-shelf policies for other AWS services. Why not also support AWS CloudFront?

gw0 avatar Dec 22 '23 12:12 gw0

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Jan 22 '24 00:01 github-actions[bot]

unstale

tculp avatar Jan 22 '24 14:01 tculp

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Feb 26 '24 00:02 github-actions[bot]

unstale

tculp avatar Feb 28 '24 21:02 tculp

@gw0 Do you still plan to continue with this PR?

tetienne-zenchef avatar Mar 26 '24 15:03 tetienne-zenchef

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Apr 26 '24 00:04 github-actions[bot]

This PR was automatically closed because of stale in 10 days

github-actions[bot] avatar May 06 '24 00:05 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Jun 05 '24 02:06 github-actions[bot]