terraform-aws-route53 icon indicating copy to clipboard operation
terraform-aws-route53 copied to clipboard

Published 20 hours ago • verified publisher icon terraform-aws-modules

feat: Add vpc association authorization flow (for cross account access to private zone)

Open alemairebe opened this issue 2 years ago • 1 comments

Description

Adding an extra parameter to the existing zones variable in the zone module to split same AWS account from others AWS accounts owned VPCs

Motivation and Context

It allows use of this module to initiate a VPC association if the VPC is in another account than the Route53 private zone. The secondary new module allows to complete that association.

Seems to fix https://github.com/terraform-aws-modules/terraform-aws-route53/issues/77 I didn't check issues upfront

Breaking Changes

It does not break compatibility with previous releases

How Has This Been Tested?

  • [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [x] I have tested and validated these changes using one or more of the provided examples/* projects
  • [x] I have executed pre-commit run -a on my pull request

alemairebe avatar Jul 25 '22 13:07 alemairebe

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Aug 28 '22 00:08 github-actions[bot]

This PR was automatically closed because of stale in 10 days

github-actions[bot] avatar Sep 08 '22 00:09 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Oct 28 '22 02:10 github-actions[bot]