terraform-aws-notify-slack icon indicating copy to clipboard operation
terraform-aws-notify-slack copied to clipboard

AWS Lambda runtime python3.8 deprecation

Open rymancl opened this issue 11 months ago β€’ 1 comments

Is your request related to a problem? Please describe.

AWS has announced the upcoming deprecation of the Lambda runtime python3.8, currently noted as Oct 14, 2024. https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html#runtimes-supported

This module has python3.8 as a hardcoded argument value to the terraform-aws-modules/lambda/aws module. https://github.com/terraform-aws-modules/terraform-aws-notify-slack/blob/96153e301b2e88ec4d032639db0337354463e607/main.tf#L82C14-L82C46

Describe the solution you'd like.

Use a runtime version that is not marked to be deprecated.

Describe alternatives you've considered.

N/A

Additional context

Related: #200

rymancl avatar Mar 06 '24 15:03 rymancl

I'm happy to work on this, just let me know the preferred approach.

  • Hard-code a higher runtime version
  • Allow runtime to be configurable via variable
  • ???

rymancl avatar Mar 06 '24 15:03 rymancl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Apr 06 '24 00:04 github-actions[bot]

commenting to remove stale label

rymancl avatar Apr 06 '24 15:04 rymancl

Comment to remove stale

aldenquimby avatar Apr 20 '24 11:04 aldenquimby

Probably would make sense to make the Python runtime configurable instead of hard-coding it. At least, I'm currently receiving AWS warnings on my company support address because of multiple accounts using Python 3.8 for the SNS function.

jessestippel avatar Apr 22 '24 12:04 jessestippel

This issue has been resolved in version 6.3.0 :tada:

antonbabenko avatar Apr 22 '24 15:04 antonbabenko

I've got this error with the updated module:

β”‚ Error: expected runtime to be one of [nodejs nodejs4.3 nodejs6.10 nodejs8.10 nodejs10.x nodejs12.x nodejs14.x nodejs16.x java8 java8.al2 java11 python2.7 python3.6 python3.7 python3.8 python3.9 dotnetcore1.0 dotnetcore2.0 dotnetcore2.1 dotnetcore3.1 dotnet6 nodejs4.3-edge go1.x ruby2.5 ruby2.7 provided provided.al2 nodejs18.x python3.10 java17], got python3.11

It looks like my account doesn't have python3.11 yet. Can you make the runtime into a variable so I can just modify it to python3.10? That would make this upgrade pretty easy for me.

chrisgilmerproj avatar Apr 23 '24 20:04 chrisgilmerproj

@chrisgilmerproj Make sure that you updated the Terraform AWS provider to version 5.11.0 or newer.

antonbabenko avatar Apr 24 '24 13:04 antonbabenko

@antonbabenko - thank you, I should have checked that first. I appreciate it.

chrisgilmerproj avatar Apr 24 '24 16:04 chrisgilmerproj

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 25 '24 02:05 github-actions[bot]