terraform-aws-iam icon indicating copy to clipboard operation
terraform-aws-iam copied to clipboard

feat: Add support for S3 CSI

Open josmo opened this issue 1 year ago β€’ 1 comments

Description

Adding the required policy for the S3 CSI driver

Motivation and Context

Fixes https://github.com/terraform-aws-modules/terraform-aws-iam/issues/456

Breaking Changes

No breaking changes - simply addition for the policy required for the S3 CSI

How Has This Been Tested?

  • [X] I have tested using my branch version with a deployment both with default * buckets and specific bucket arns
  • [X] I have executed pre-commit run -a on my pull request

josmo avatar Feb 13 '24 16:02 josmo

Thanks a ton for the comments @bryantbiggs I think I have everything working and I also did validate with the working config I have before these updates (and temp move blocks for the resources that there were no plan changes) let me know if I need to change anything else.

josmo avatar Feb 22 '24 14:02 josmo

@antonbabenko - FYI, I had to add a hack into the pre-commit workflow since it looks like the Terraform bits are getting big and filling up disk. I wonder if this is related to the AWS SDK Go v1 to v2 migration - https://github.com/terraform-aws-modules/terraform-aws-iam/actions/runs/8126685348/job/22210719103?pr=459

image

bryantbiggs avatar Mar 03 '24 01:03 bryantbiggs

This PR is included in version 5.36.0 :tada:

antonbabenko avatar Mar 03 '24 01:03 antonbabenko

@antonbabenko - FYI, I had to add a hack into the pre-commit workflow since it looks like the Terraform bits are getting big and filling up disk. I wonder if this is related to the AWS SDK Go v1 to v2 migration - terraform-aws-modules/terraform-aws-iam/actions/runs/8126685348/job/22210719103?pr=459

Thanks for finding the solution to this problem. I thought it was related to many runs of "terraform init", but it is very good to have more space and delete stuff (another way to get more space - https://github.com/k8sgpt-ai/k8sgpt/pull/947 :) ).

antonbabenko avatar Mar 03 '24 01:03 antonbabenko

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Apr 02 '24 02:04 github-actions[bot]