terraform-aws-eventbridge
terraform-aws-eventbridge copied to clipboard
feat: Enable `enable_ecs_managed_tags`
This enables the setting of the enable_ecs_managed_tags property - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_event_target#enable_ecs_managed_tags
Description
Without this setting, you cannot set up managed tags
Motivation and Context
I wanted to have the targets be able to have the cluster and service automatically added to each job that ran
Breaking Changes
This is available in the latest major version of the AWS provider
How Has This Been Tested?
- [x] I have updated at least one of the
examples/*
to demonstrate and validate my change(s) - [x] I have tested and validated these changes using one or more of the provided
examples/*
projects
- [x] I have executed
pre-commit run -a
on my pull request
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
Is there a reason why this should not be merged in?
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
Could you include the propagate_tags
on this MR?
I imported a resource previously created on AWS Portal and it wants to change the propagate_tags
as well as enable_ecs_managed_tags
My plan:
# module.eventbridge.aws_cloudwatch_event_target.this["X"] will be updated in-place
~ resource "aws_cloudwatch_event_target" "this" {
id = "X-Id86b54c07-94d6-49c0-bd6b-dac1515e6eeb"
+ input = (sensitive)
+ input_path = ""
# (5 unchanged attributes hidden)
~ ecs_target {
~ enable_ecs_managed_tags = true -> false
+ propagate_tags = "TASK_DEFINITION"
tags = {}
# (3 unchanged attributes hidden)
}
}
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
This PR was automatically closed because of stale in 10 days
I'm going to lock this pull request because it has been closed for 30 days β³. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.