fix: Update node_iam_role_arns locals to check for Windows Managed Node Groups

[aamoctz]

Description

This change adds additional checks for platform == "windows" on both local.node_iam_role_arns_non_windows and local.node_iam_role_arns_windows.

The additional validation in local.node_iam_role_arns_windows ensures that the correct configurations are added to aws-auth.

The additiional validation in local.node_iam_role_arns_non_windows ensures that terraform does not also create an extra incorrect entry in aws-auth for the node group.

To support this change, the eks_managed_node_group module has a new output (platform)

Motivation and Context

Resolves the issue described in this comment from #2350

Breaking Changes

No breaking changes found during my testing.

How Has This Been Tested?

• [] I have updated at least one of the examples/* to demonstrate and validate my change(s)
• [x] I have tested and validated these changes using one or more of the provided examples/* projects

• [x] I have executed pre-commit run -a on my pull request

[hp197]

👍

[noamgreen]

can someone approve this :-)

[github-actions[bot]]

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

[hp197]

bump

[github-actions[bot]]

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

[aamoctz]

bump

[mcmagi]

I would also greatly appreciate a review of this. Thanks!

[jxn]

I've nearly submitted this exact same code in a different PR today. Even with today's master, the changes are the same. It would be great to get this reviewed and pulled in so managed windows node groups can be functional instances.

[saedx1]

Can we please get this reviewed and merged? It's really needed!

[bryantbiggs]

how has this been tested and validated?

[mlschindler]

+1 this PR would benefit us greatly

[aamoctz]

how has this been tested and validated?

PR was tested using the eks_managed_node_group example module, with some modifications to use existing VPC related resources since those are managed elsewhere within my org. I do not have access to a sandbox account so that's the closest I can get.

[sean-redmond]

This looks good in some limited testing, given the problems this is currently causing I think it should be pulled in.

[sankalpkale88]

+1 Can we please get this merged ?

[github-actions[bot]]

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

[sean-redmond]

Would be really nice to see this merged.

[kirillowen]

+1 Would be great to see this merged.

[antonbabenko]

This PR is included in version 19.16.0 :tada:

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.