terraform-aws-eks
terraform-aws-eks copied to clipboard
terraform-aws-modules
Attribute-Based Instance Type Selection for node groups
Is your request related to a new offering from AWS?
Yes, see: https://aws.amazon.com/blogs/aws/new-attribute-based-instance-type-selection-for-ec2-auto-scaling-and-ec2-fleet/ https://docs.aws.amazon.com/autoscaling/ec2/userguide/create-asg-instance-type-requirements.html
The feature is not yet implemented in the Terraform AWS provider, see corresponding issue: https://github.com/hashicorp/terraform-provider-aws/issues/21566
This would be a great feature for node groups using SPOT or ON DEMAND with instance diversification. It would simplify node group configuration and make it future proof by just provision the needed resources (for example vCPU and memory) and let the corresponding AWS API pickup suitable instance types even new ones as they become available.
This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue was automatically closed because of stale in 10 days
This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days
This issue was automatically closed because of stale in 10 days
Would a maintainer please reopen and stop the bot from marking this stale?
Launch template support has been added to the AWS provider, we still need autoscaling group support as well https://github.com/hashicorp/terraform-provider-aws/issues/21566
@bryantbiggs I believe https://github.com/hashicorp/terraform-provider-aws/issues/21566 doesn't cover the aws_eks_node_group resource unless I have missed something. :-)
May be we look at using ec2_instance_types data source to implement instance selector similar to how eksctl does here
Any thoughts?
Correct - getting it into the EKS managed node group is a whole different ball of yarn. First we need the EKS service to support it in managed node groups, then the AWS provider will need to update (possibly, depending on implementation/API). We could try passing a launch template with the attribute based instance selection and see what happens - haven't tried that myself 🤷🏽
https://github.com/hashicorp/terraform-provider-aws/issues/21566 is now closed so work on this can progress.
v19 needs to be released to increase the provider version to at least v4.x first
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.