terraform-aws-ecs icon indicating copy to clipboard operation
terraform-aws-ecs copied to clipboard

Add support for volumes in task definitions

Open compdemo0908 opened this issue 2 years ago β€’ 2 comments

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too. - Yes βœ…: please list the AWS provider version which introduced this functionality aws_ecs_task_definition add argument for volumes: https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#3450-june-10-2021

Is your request related to a problem? Please describe.

Create services with task definitions that support volumes, i.e. EFS or FSx: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecs_task_definition#volume

when finishing the TODO list for the service submodule: https://github.com/terraform-aws-modules/terraform-aws-ecs/tree/master/modules/service

Describe the solution you'd like.

Create a module input to support volume arguments in the aws_ecs_task_definition that's already in the TODO list of the Read.Me

Describe alternatives you've considered.

This third party module: https://github.com/techservicesillinois/terraform-aws-ecs-service#network_configuration

Additional context

Third party module has too many co-dependencies and it's almost sunset. For example, when creating a service with a LB the Default Forward Rule can't be used but a Host Condition is required. Adding un-necessary complexity.

compdemo0908 avatar Sep 20 '22 00:09 compdemo0908

Currently, this module is under active development, and such feature request is already among TODO's here - https://github.com/terraform-aws-modules/terraform-aws-ecs/tree/master/modules/service#todo

@bryantbiggs Please correct me if I am wrong.

antonbabenko avatar Sep 20 '22 14:09 antonbabenko

correct - we will have support for this shortly

bryantbiggs avatar Sep 21 '22 06:09 bryantbiggs

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Oct 22 '22 00:10 github-actions[bot]

This issue was automatically closed because of stale in 10 days

github-actions[bot] avatar Nov 02 '22 00:11 github-actions[bot]

This ticket shouldn't be closed as it's not yet resolved.

gruckion avatar Nov 07 '22 15:11 gruckion

ref https://github.com/terraform-aws-modules/terraform-aws-ecs/compare/master...bryantbiggs:terraform-aws-ecs:feat/service?expand=1

bryantbiggs avatar Nov 07 '22 15:11 bryantbiggs

I noticed that there is a PR for this. When will this be rolled out?

vishwa-trulioo avatar Jan 16 '23 20:01 vishwa-trulioo

soon - we are testing the changes against known patterns and examples first. It just takes some time but it is actively being worked on

bryantbiggs avatar Jan 16 '23 21:01 bryantbiggs

ref https://github.com/terraform-aws-modules/terraform-aws-ecs/compare/master...bryantbiggs:terraform-aws-ecs:feat/service?expand=1

When this PR is created and subsequently rolled out, will this allow creation of the actual ECS service and task definition? Or what all functionality will be included there?

ahummel25 avatar Jan 28 '23 20:01 ahummel25

Yes - this module should cover all of the different facets provided by ECS today (as supported by the Terraform provider of course)

bryantbiggs avatar Jan 28 '23 20:01 bryantbiggs

Thanks so much for actively working on this!

compdemo0908 avatar Jan 31 '23 18:01 compdemo0908

Thanks so much for actively working on this!

victorcechinel avatar Mar 31 '23 16:03 victorcechinel

This issue has been resolved in version 5.0.0 :tada:

antonbabenko avatar Apr 21 '23 11:04 antonbabenko

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 22 '23 02:05 github-actions[bot]