fix: Remove deprecated variables

[globart]

Description

Removed mentions of deprecated cpu_core_count and cpu_threads_per_core variables

Motivation and Context

Breaking Changes

No

How Has This Been Tested?

• [ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
• [ ] I have tested and validated these changes using one or more of the provided examples/* projects

• [ ] I have executed pre-commit run -a on my pull request

[eternityduck]

Nice

[github-actions[bot]]

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

[ait-artem-stankov]

@antonbabenko please check

[bryantbiggs]

we'll proceed once AWS provider v6 arrives - this was originally meant to arrive in April but seems to be taking a bit longer

[gurpreetatwal]

@bryantbiggs looks like the provider was just released today :D

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-6-upgrade

I'd recommend either merging this PR and any other updates for v6 or temporarily updating versions.tf to cap the provider at < 6

I got the misfortune of following a tutorial a few hours after the publish and running into errors 😅

[andrealiz-saildrone]

Any ETA on when this can be merged? Currently hitting this error when I try to do a plan against the module:

An argument named "cpu_core_count" is not expected here.

[bryantbiggs]

Pin your required_providers, we'll deal with breaking changes when we can

[aristosvo]

ℹ️ block_duration_minutes on aws_spot_instance_request seems also not longer supported

╷
│ Error: Unsupported argument
│ 
│   on .terraform/modules/ec2_module.ec2/main.tf line 418, in resource "aws_spot_instance_request" "this":
│  418:   block_duration_minutes         = var.spot_block_duration_minutes
│ 
│ An argument named "block_duration_minutes" is not expected here.
╵

[mcksatish]

Pin your required_providers, we'll deal with breaking changes when we can

Terraform provider version used - 5.26.0 Facing these errors; I would appreciate if this PR can be merged sooner:

  on .terraform/main.tf line 145, in resource "aws_spot_instance_request" "this":
 145:   cpu_core_count       = var.cpu_core_count

An argument named "cpu_core_count" is not expected here.


Error: Unsupported argument

  on .terraform/main.tf line 146, in resource "aws_spot_instance_request" "this":
 146:   cpu_threads_per_core = var.cpu_threads_per_core

An argument named "cpu_threads_per_core" is not expected here.


Error: Unsupported argument

  on .terraform/main.tf line 173, in resource "aws_spot_instance_request" "this":
 173:   block_duration_minutes         = var.spot_block_duration_minutes

An argument named "block_duration_minutes" is not expected here.

[githubtlvmc]

Facing same errors; I would appreciate if this PR can be merged sooner:

[bryantbiggs]

we aren't merging this PR as it stands - we are working on making changes that are necessary with a breaking change - hopefully that lands today or tomorrow

[githubtlvmc]

we aren't merging this PR as it stands - we are working on making changes that are necessary with a breaking change - hopefully that lands today or tomorrow

thanks!!!

[antonbabenko]

This issue has been resolved in version 6.0.0 :tada:

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.