terraform-aws-ec2-instance icon indicating copy to clipboard operation
terraform-aws-ec2-instance copied to clipboard

feat: Use a map for root_block_device instead of list

Open Yethal opened this issue 1 year ago β€’ 5 comments

Description

root_block_device variable is now a map instead of list of maps.

Motivation and Context

Since aws_instance resource only allows for a single root_block_device it makes no sense to use a list since it will only ever accept a single element. Moreover storing this configuration in a map instead of wrapping it with a list will make it easier to use with Terragrunt and deep merged configs

Breaking Changes

Yes

Streamline and simplify usage with wrapping automation

How Has This Been Tested?

  • [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [x] I have tested and validated these changes using one or more of the provided examples/* projects
  • [x] I have executed pre-commit run -a on my pull request

Yethal avatar Jun 19 '24 18:06 Yethal

@antonbabenko Can we merge this?

Yethal avatar Jul 23 '24 13:07 Yethal

This breaking change brings little improvements, so I don't think we need to introduce it now. Maybe in the future (during the next major release).

antonbabenko avatar Aug 09 '24 17:08 antonbabenko

upvote

ThickDrinkLots avatar Aug 26 '24 11:08 ThickDrinkLots

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Sep 26 '24 00:09 github-actions[bot]

unstale I'd like to keep this open so it gets merged together with whatever change bumps the major version number

Yethal avatar Sep 26 '24 08:09 Yethal

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Oct 27 '24 00:10 github-actions[bot]

unstale

Yethal avatar Oct 28 '24 11:10 Yethal

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Nov 28 '24 00:11 github-actions[bot]

unstale

Yethal avatar Nov 28 '24 07:11 Yethal

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Dec 30 '24 00:12 github-actions[bot]

unstale

Yethal avatar Dec 30 '24 09:12 Yethal

@antonbabenko how about a major release on New Year?

Yethal avatar Dec 30 '24 09:12 Yethal

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Jan 31 '25 00:01 github-actions[bot]

unstale

Yethal avatar Jan 31 '25 07:01 Yethal

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Mar 03 '25 00:03 github-actions[bot]

unstale

Yethal avatar Mar 03 '25 15:03 Yethal

closing for now - please open an issue and we can track that for the next breaking change

bryantbiggs avatar Mar 30 '25 20:03 bryantbiggs

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 01 '25 02:05 github-actions[bot]

This issue has been resolved in version 6.0.0 :tada:

antonbabenko avatar Jun 24 '25 19:06 antonbabenko