terraform-aws-ec2-instance
terraform-aws-ec2-instance copied to clipboard
feat: Use a map for root_block_device instead of list
Description
root_block_device variable is now a map instead of list of maps.
Motivation and Context
Since aws_instance resource only allows for a single root_block_device it makes no sense to use a list since it will only ever accept a single element. Moreover storing this configuration in a map instead of wrapping it with a list will make it easier to use with Terragrunt and deep merged configs
Breaking Changes
Yes
Streamline and simplify usage with wrapping automation
How Has This Been Tested?
- [x] I have updated at least one of the
examples/*to demonstrate and validate my change(s) - [x] I have tested and validated these changes using one or more of the provided
examples/*projects
- [x] I have executed
pre-commit run -aon my pull request
@antonbabenko Can we merge this?
This breaking change brings little improvements, so I don't think we need to introduce it now. Maybe in the future (during the next major release).
upvote
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
unstale I'd like to keep this open so it gets merged together with whatever change bumps the major version number
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
unstale
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
unstale
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
unstale
@antonbabenko how about a major release on New Year?
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
unstale
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
unstale
closing for now - please open an issue and we can track that for the next breaking change
I'm going to lock this pull request because it has been closed for 30 days β³. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
This issue has been resolved in version 6.0.0 :tada: