Adding tags to spot instances

[shaked-tech]

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

• No 🛑: please wait to file a request until the functionality is available in the AWS provider
• Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.

When creating spot instances the tags are only added to the spot request.

Describe the solution you'd like.

It would be nice if there was a bool option to add the tags to the instances themselves, additionally, it could be valid that by default only the Name key would be added (as it is already set by default) because to be honest most time were looking at the instances themselves and not the spot requests

Describe alternatives you've considered.

The alternative I used is to loop through the Module instances and add tags to the instances manually using 'aws_ec2_tag' resource.

Additional context

I can open a PR if needed :) thanks in advance!

[github-actions[bot]]

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions[bot]]

This issue was automatically closed because of stale in 10 days

[github-actions[bot]]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.