terraform-aws-customer-gateway icon indicating copy to clipboard operation
terraform-aws-customer-gateway copied to clipboard

Published 20 hours ago • verified publisher icon terraform-aws-modules

feat: Adjust optional params for the aws_customer_gateway, add device_name and certificate_arn

Open Art3mK opened this issue 1 year ago • 2 comments

Description

Adding optional param device_name to the cgw

Motivation and Context

I've got few existing VPN tunnels I'd like to move under tf management, and some cgws have that device_name set, but module doesn't allow to set it. Missing device_name results in cgw recreation.

Breaking Changes

n/a

How Has This Been Tested?

  • [ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [x] I have tested and validated these changes using one or more of the provided examples/* projects
  • [x] I have executed pre-commit run -a on my pull request

Trivial change, so just tested in my env this solves the problem.

Art3mK avatar May 30 '24 11:05 Art3mK

@antonbabenko could you review, plz 🙏

Art3mK avatar May 31 '24 06:05 Art3mK

ping @antonbabenko 🙏

Art3mK avatar Jun 17 '24 06:06 Art3mK

ping @antonbabenko 🙏

Art3mK avatar Oct 16 '24 05:10 Art3mK

ping @antonbabenko 🙏

Art3mK avatar Feb 21 '25 10:02 Art3mK

Thank you for this addition. I have removed validation from the variable.

antonbabenko avatar Mar 05 '25 00:03 antonbabenko

This PR is included in version 3.1.0 :tada:

antonbabenko avatar Mar 05 '25 00:03 antonbabenko

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Apr 04 '25 02:04 github-actions[bot]