terraform-aws-apigateway-v2 icon indicating copy to clipboard operation
terraform-aws-apigateway-v2 copied to clipboard

feat!: Updates to support websocket API Gateway

Open bryantbiggs opened this issue 3 years ago β€’ 12 comments

Description

  • bump min version of Terraform supported to 0.13.1
  • bump min version of AWS provider supported to 3.35 for request_parameter support (websocket)
  • update example to use tfvars/variable for testing with users own domain
  • add output for routes which have a map of maps input - so all route resources and their attributes are lazily exported
  • add conditional check blocks for if target type is HTTP or WEBSOCKET
  • re-enable route_settings
  • add fail_on_warnings attribute to aws_apigatewayv2_api
  • add a depends_on on aws_apigatewayv2_route so that example deployes in one apply successfully
  • add api_mapping_key to API mapping resource (websocket)
  • add authorization_scopes, request_models, and request_parameter attributes to aws_apigatewayv2_route
  • renamed default_stage_xxx references to just stage_xxx

Motivation and Context

  • updates for websocket support

Closes #7 Closes #8 Closes #42 Closes #46 Closes #61

Breaking Changes

  • maybe;
    • Terraform 0.12 support is dropped
    • default_stage_xxx references changed to stage_xxx
      Was Is Now
      create_default_stage create_stage
      create_default_stage_api_mapping create_stage_api_mapping
      default_stage_tags stage_tags
      default_stage_access_log_format stage_access_log_format
      default_stage_access_log_destination_arn stage_access_log_destination_arn

How Has This Been Tested?

  • [x] I have tested and validated these changes using one or more of the provided examples/* projects
    • tested using complete-http example
    • websocket example added

bryantbiggs avatar Sep 09 '21 16:09 bryantbiggs

Not sure if this affects #46 at all. That PR had a working example of a websockets API. I can update if needed.

lllama avatar Sep 09 '21 21:09 lllama

@lllama Thanks for the WebSocket example in #46!

I think it will be great if @bryantbiggs merges your example into this PR and update it to follow the rest of the examples we have.

antonbabenko avatar Sep 10 '21 07:09 antonbabenko

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Feb 11 '22 01:02 github-actions[bot]

Shhhh

bryantbiggs avatar Feb 11 '22 01:02 bryantbiggs

I'm interested on this, any updates?

zkRemda avatar Feb 19 '22 19:02 zkRemda

Is this feature just awaiting a review? This would be a great addition as we can't use this module as is.

schlbra avatar May 26 '22 18:05 schlbra

Is this feature just awaiting a review? This would be a great addition as we can't use this module as is.

its waiting on me to finish it up, running a bit behind - my apologies. once I get https://github.com/terraform-aws-modules/terraform-aws-redshift/pull/61 across the line I'll focus on finish this one up as well

bryantbiggs avatar May 26 '22 18:05 bryantbiggs

any update on this?

krishna-koushik avatar Nov 12 '22 01:11 krishna-koushik

@bryantbiggs Do you want me to work on this one? I am interested in improving https://serverless.tf , so this is a good addition.

antonbabenko avatar Nov 12 '22 14:11 antonbabenko

@antonbabenko yes, please feel free to take this one over if you have the time

bryantbiggs avatar Nov 12 '22 14:11 bryantbiggs

Ok, I will work on it on Monday-Wednesday then.

antonbabenko avatar Nov 12 '22 14:11 antonbabenko

Hi, are there any updates regarding this one? I'm really interested in this

ghost avatar Aug 16 '23 10:08 ghost

Can We merge this pull request?

choudharyac09 avatar May 13 '24 18:05 choudharyac09

Can We merge this pull request?

Its being worked on, its currently in draft mode

bryantbiggs avatar May 13 '24 18:05 bryantbiggs

@antonbabenko Can you please review the pull request?

choudharyac09 avatar May 14 '24 20:05 choudharyac09

@antonbabenko Can you please review the pull request?

Yes, as soon as I can. Probably, tomorrow.

antonbabenko avatar May 14 '24 20:05 antonbabenko

This PR is included in version 5.0.0 :tada:

antonbabenko avatar Jun 04 '24 15:06 antonbabenko