terraform-aws-apigateway-v2
terraform-aws-apigateway-v2 copied to clipboard
feat!: Updates to support websocket API Gateway
Description
- bump min version of Terraform supported to 0.13.1
- bump min version of AWS provider supported to 3.35 for
request_parametersupport (websocket) - update example to use tfvars/variable for testing with users own domain
- add output for routes which have a map of maps input - so all route resources and their attributes are lazily exported
- add conditional check blocks for if target type is
HTTPorWEBSOCKET - re-enable
route_settings - add
fail_on_warningsattribute toaws_apigatewayv2_api - add a
depends_ononaws_apigatewayv2_routeso that example deployes in one apply successfully - add
api_mapping_keyto API mapping resource (websocket) - add
authorization_scopes,request_models, andrequest_parameterattributes toaws_apigatewayv2_route - renamed
default_stage_xxxreferences to juststage_xxx
Motivation and Context
- updates for websocket support
Closes #7 Closes #8 Closes #42 Closes #46 Closes #61
Breaking Changes
- maybe;
- Terraform 0.12 support is dropped
default_stage_xxxreferences changed tostage_xxxWas Is Now create_default_stagecreate_stagecreate_default_stage_api_mappingcreate_stage_api_mappingdefault_stage_tagsstage_tagsdefault_stage_access_log_formatstage_access_log_formatdefault_stage_access_log_destination_arnstage_access_log_destination_arn
How Has This Been Tested?
- [x] I have tested and validated these changes using one or more of the provided
examples/*projects- tested using
complete-httpexample websocketexample added
- tested using
Not sure if this affects #46 at all. That PR had a working example of a websockets API. I can update if needed.
@lllama Thanks for the WebSocket example in #46!
I think it will be great if @bryantbiggs merges your example into this PR and update it to follow the rest of the examples we have.
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
Shhhh
I'm interested on this, any updates?
Is this feature just awaiting a review? This would be a great addition as we can't use this module as is.
Is this feature just awaiting a review? This would be a great addition as we can't use this module as is.
its waiting on me to finish it up, running a bit behind - my apologies. once I get https://github.com/terraform-aws-modules/terraform-aws-redshift/pull/61 across the line I'll focus on finish this one up as well
any update on this?
@bryantbiggs Do you want me to work on this one? I am interested in improving https://serverless.tf , so this is a good addition.
@antonbabenko yes, please feel free to take this one over if you have the time
Ok, I will work on it on Monday-Wednesday then.
Hi, are there any updates regarding this one? I'm really interested in this
Can We merge this pull request?
Can We merge this pull request?
Its being worked on, its currently in draft mode
@antonbabenko Can you please review the pull request?
@antonbabenko Can you please review the pull request?
Yes, as soon as I can. Probably, tomorrow.
This PR is included in version 5.0.0 :tada: