terraform-aws-acm icon indicating copy to clipboard operation
terraform-aws-acm copied to clipboard

Ability to support multiple hostnames and DNS zones

Open rapides opened this issue 2 years ago β€’ 20 comments
trafficstars

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • Yes βœ…: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.

I cannot select more zone_id when I want to support more than one DNS name with totally different hostnames. In order to create CloudFront distribution that uses 2 totally different domains at the same time (example: example.com and example.co) and I need to use a single SSL certificate that whitelists 2 different hostnames. In such cases, each domain has to have a separate DNS zone.

Describe the solution you'd like.

Ability to enter domains and zones together via a single variable, so you can easily distinguish when you need to create DNS records in separate DNS zones.

Describe alternatives you've considered.

N/A

Additional context

rapides avatar Aug 18 '23 09:08 rapides

We are having the same need, would be great to genera an ACM certificate with multiple domains so we don't have to create multiple CloudFront distributions.

amontalban avatar Sep 11 '23 12:09 amontalban

@rapides can you try #137 and see if that works for you? Thanks!

amontalban avatar Sep 13 '23 21:09 amontalban

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Oct 14 '23 00:10 github-actions[bot]

I have the same issue

phuhl avatar Oct 16 '23 08:10 phuhl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Nov 17 '23 00:11 github-actions[bot]

Issue still perists

phuhl avatar Nov 17 '23 13:11 phuhl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Dec 18 '23 00:12 github-actions[bot]

Issue still perists

phuhl avatar Dec 18 '23 08:12 phuhl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Jan 18 '24 00:01 github-actions[bot]

Issue still perists

phuhl avatar Jan 23 '24 14:01 phuhl

https://github.com/terraform-aws-modules/terraform-aws-acm/pull/137#pullrequestreview-1662067778 - my review is still relevant and someone can take it further and work on improvements.

antonbabenko avatar Jan 26 '24 10:01 antonbabenko

Hi @amontalban, do you intend to resume #137? Otherwise I think I could make requested changes.

alemarmed avatar Feb 02 '24 16:02 alemarmed

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Mar 04 '24 00:03 github-actions[bot]

Issue still perists, I don't know the code in here at all, so I am not sure, it makes sense for me to work on this, but @amontalban maybe you could create a new PR based on #137?

phuhl avatar Mar 05 '24 08:03 phuhl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Apr 05 '24 00:04 github-actions[bot]

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

phuhl avatar Apr 05 '24 14:04 phuhl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar May 06 '24 00:05 github-actions[bot]

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

phuhl avatar May 06 '24 13:05 phuhl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Jun 06 '24 00:06 github-actions[bot]

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

phuhl avatar Jun 10 '24 13:06 phuhl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Jul 11 '24 00:07 github-actions[bot]

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

phuhl avatar Jul 11 '24 09:07 phuhl

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Aug 11 '24 00:08 github-actions[bot]

Issue still persists, waiting for https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149

phuhl avatar Aug 12 '24 13:08 phuhl

@phuhl it's your turn to check it out and open an issue if you see something wrong. I'm sorry it took so long to get this one reviewed and merged.

antonbabenko avatar Aug 13 '24 00:08 antonbabenko

Thank you for putting the work in :)

phuhl avatar Aug 14 '24 09:08 phuhl

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Sep 14 '24 02:09 github-actions[bot]