terraform-aws-acm icon indicating copy to clipboard operation
terraform-aws-acm copied to clipboard

Published 20 hours ago • verified publisher icon terraform-aws-modules

feat: Added extension for alternative zone_id's for SAN's

Open ZeePal opened this issue 3 years ago • 9 comments

Description

This is a proposed change to keep backwards compatibility while providing functionality to allow subject alternative names to optionally include a different Route53 Zone ID (if not provided assume var.zone_id)

Motivation and Context

Resolves: https://github.com/terraform-aws-modules/terraform-aws-acm/issues/21

This is an alternative approach to https://github.com/terraform-aws-modules/terraform-aws-acm/pull/91 but to keep extra data objects outside of the module. This implementation doesnt use data route53 calls and keeps provider & terraform version backwards compatibility while using explicit configuration for the SAN you wish to handle differently.

Breaking Changes

Should be fully backwards compatible. The try() calls allow both old (strings) and alternative (map) representations of each SAN element.

How Has This Been Tested?

  • [X] I have tested and validated these changes using one or more of the provided examples/* projects

Tested with DNS example and created a DNS example for multiple Route53 zones which was also tested with the below combinations:

  • TF0.12.26 & Provider 2.53
  • TF1.0.10 & Provider 3.71

ZeePal avatar Jan 13 '22 03:01 ZeePal

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Feb 16 '22 00:02 github-actions[bot]

Hi @antonbabenko , don't wana pressure/rush anything. just commenting to keep the bot from closing :)

ZeePal avatar Feb 28 '22 00:02 ZeePal

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Apr 01 '22 00:04 github-actions[bot]

Would be great to get this across.

@ZeePal it seems there are some conflicts I guess meanwhile you can try and solve them?

Please Mr Bot don't close this PR

FabioAntunes avatar Apr 01 '22 10:04 FabioAntunes

@FabioAntunes srry for the delay, git conflict resolved. be kind for a little longer Mr Bot.

ZeePal avatar Apr 14 '22 05:04 ZeePal

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar May 17 '22 00:05 github-actions[bot]

Mr bot, don't

FabioAntunes avatar May 17 '22 09:05 FabioAntunes

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Jul 17 '22 00:07 github-actions[bot]

Mr bot, stop trying to close this.

FabioAntunes avatar Jul 18 '22 14:07 FabioAntunes

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Aug 19 '22 00:08 github-actions[bot]

This PR was automatically closed because of stale in 10 days

github-actions[bot] avatar Sep 02 '22 00:09 github-actions[bot]

Can this be reopened?

FabioAntunes avatar Sep 05 '22 10:09 FabioAntunes

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Nov 15 '22 02:11 github-actions[bot]