terraform-provider-virtualbox icon indicating copy to clipboard operation
terraform-provider-virtualbox copied to clipboard

Published 20 hours ago • verified publisher icon terra-farm

feat: allow setting vm firmware

Open ghouscht opened this issue 3 years ago • 2 comments

Hi, As stated in https://github.com/terra-farm/go-virtualbox/pull/28 I need this to create VMs which only support EFI boot, which is now working with these changes. Thank you, Thomas

ghouscht avatar Jan 07 '22 07:01 ghouscht

The changes you added look good, but what is missing is adding the ability to read the firmware back in resourceVMRead function.

if err = d.Set("firmware", vm.Firmware); err != nil {
	return diag.Errorf("can't set firmware: %v", err)
}

Uh, good catch, I missed that, sorry. Also done with the latest changes.

ghouscht avatar Jan 07 '22 15:01 ghouscht

HI @VoyTechnology, Any chance to get this merged in the near future? Thanks, Thomas

ghouscht avatar Jan 29 '22 10:01 ghouscht