go-virtualbox icon indicating copy to clipboard operation
go-virtualbox copied to clipboard

Make regular expression for guestproperty extraction case insensitive

Open nikstuckenbrock opened this issue 1 year ago • 1 comments

When investigating on the issue 149 in the terra-farm/terraform-provider-virtualbox repository I found out that the issue mentioned there was not part of the provider but of the go interface for virtualbox.

The regular expression which extracts the value from the guestproperty get command only checks for Value written in that exact case. For my installation of VirtualBox this doesn't match. My output from guestproperty get looks like this:

Name: /VirtualBox/GuestInfo/Net/0/V4/IP, value: 192.168.56.118, timestamp: 1666676579936956000, flags:

I've changed the regex so that it should allow both and provided a new test case for this. Please let me know if you need further information on something. Thanks in advance!

nikstuckenbrock avatar Oct 25 '22 06:10 nikstuckenbrock

PS: I would love if you add the HACKTOBERFEST-ACCEPTED label to this PR. ❤️

nikstuckenbrock avatar Oct 25 '22 06:10 nikstuckenbrock

Thanks! 🙂

nikstuckenbrock avatar Oct 26 '22 05:10 nikstuckenbrock