termux-widget icon indicating copy to clipboard operation
termux-widget copied to clipboard

Assigning script shortcut as swipe action of existing nova launcher shortcut does not work

Open macerg opened this issue 3 years ago • 14 comments

Desktop icon up/down swipe function. Cannot assign to an action. Was ok 0.12. broken in 0.13.0

macerg avatar Jul 18 '22 16:07 macerg

Working fine if you install both Nova Launcher and Nova Launcher Prime app. And swipe up/down actions are controlled by launcher, not Termux:Widget anyways.

agnostic-apollo avatar Jul 18 '22 18:07 agnostic-apollo

I know that, you try and set up a new action, the setup dialogue is screwed up. I have Nova launcher and prime installed. Worked fine for years until this update.

macerg avatar Jul 18 '22 19:07 macerg

I know that, you try and set up a new action. The setup dialogue is screwed up. I have launcher and prime installed. Worked fine for years until this update.On 18 Jul 2022 19:54, agnostic-apollo @.***> wrote: Closed #84 as not planned.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

macerg avatar Jul 18 '22 19:07 macerg

Post video/screenshot. I already tested with latest nova on Android 11 and swipe setting from long hold icon -> edit works. Make sure you recreated all shortcuts again after updating as per changelog.

https://github.com/termux/termux-widget/releases

agnostic-apollo avatar Jul 18 '22 19:07 agnostic-apollo

It won't let me recreate my actions as dialogue is screwed. I'll leave that here as I've regressed to 0.12. and all is working. I'm very confident that someone else will come across this issue and it will be fixed. Just a matter of time. Here's what I did. Created a new shortcut for a . shortcuts/task. Worked fine, now assign a 'swipe up' task to that shortcut. Dialogue takes you through creating a new shortcut & doesn't assign it to the 'swipe up' action of the previous shortcut. Bye, that's all from me.

macerg avatar Jul 19 '22 05:07 macerg

You mean assign another termux script shortcut to swipe actions of existing shortcut, you should have been more clear. Anyways, that won't work currently, since v0.13.0 due to security reasons when shortcut creation is initiated, then termux-widget sends a pinned shortcut to default launcher app on Android >= 8 and does not send back static shortcut, which is what nova expects back. Considering that this could be a security risk, since launcher will then be able to execute any scripts under allowed shortcut directories, I will have to think on whether to somehow allow this, like with a prompt.

agnostic-apollo avatar Jul 19 '22 06:07 agnostic-apollo

Ok, thanks. I should have been more clear. Thanks for reopening and recognising issue.

macerg avatar Jul 19 '22 06:07 macerg

Don't understand why this doesn't seem to be a "security issue" in 0.12 and earlier.

macerg avatar Jul 19 '22 06:07 macerg

"You mean assign another termux script shortcut to swipe actions of existing shortcut?,"Yes, I do mean that. Sorry, not clear to you.On 19 Jul 2022 07:19, agnostic-apollo @.***> wrote: You mean assign another termux script shortcut to swipe actions of existing shortcut, you should have been more clear. Anyways, that won't work currently, since v0.13.0 due to security reasons when shortcut creation is initiated, then termux-widget sends a pinned shortcut to default launcher app on Android >= 8 and does not use static shortcut, which is what nova expects back. Considering that this could be a security risk, since launcher will then be able to execute any scripts under allowed shortcut directories, I will have to think on whether to somehow allow this, like with a prompt.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

macerg avatar Jul 19 '22 07:07 macerg

It won't let me recreate my actions as dialogue is screwed. I'll leave that here as I've regressed to 0.12. and all is working. I'm very confident that someone else will come across this issue and it will be fixed. Just a matter of time.  Here's what I did. Created a new shortcut for a . shortcuts/task. Worked fine, now assign a 'swipe up' task to that shortcut. Dialogue takes you through creating a new shortcut & doesn't assign it to the 'swipe up' action of the previous shortcut. Bye, that's all from me.On 18 Jul 2022 20:18, agnostic-apollo @.***> wrote: Post video/screenshot. I already tested with latest nova on Android 11 and swipe setting from long hold icon -> edit works. Make sure you recreated all shortcuts again after updating as per changelog. https://github.com/termux/termux-widget/releases

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

macerg avatar Oct 11 '22 07:10 macerg

Same issues here, and not only Nova Launcher. Instead of assigning to an action, it(v0.13) just creates a new shortcut icon on Home screen. v0.12 works fine.

L-Cool-J avatar Nov 10 '22 03:11 L-Cool-J

No signs of being fixed yet then?

macerg avatar Nov 10 '22 03:11 macerg

It has already been fixed locally, will push changes after termux-app/termux-shared ones are.

agnostic-apollo avatar Nov 10 '22 07:11 agnostic-apollo

It has already been fixed locally, will push changes after termux-app/termux-shared ones are.

Any news on when this fix will be released?

SF73 avatar Jan 27 '23 11:01 SF73