termux-packages icon indicating copy to clipboard operation
termux-packages copied to clipboard

addpkg(main/vlang): 0.4.12

Open ilyas-ozt opened this issue 1 month ago • 3 comments

ilyas-ozt avatar Oct 28 '25 20:10 ilyas-ozt

We really gotta talk about using a rebase workflow for your PRs, this is what attempt number 4 at this now? You could have just made your changes, committed them with git commit --amend, and force pushed the changes with git push --force-with-lease --force-if-includes. Opening a new PR is not necessary to make changes to it.

Making a separate development branch for your PRs is also generally helpful, but that boat has sailed for this PR so I'll just mention it as a general suggestion.

TomJo2000 avatar Oct 28 '25 21:10 TomJo2000

This PR seems close to actually being a merge-able build script for vlang.

Unfortunately, not quite yet - if you look closely, you can see that this PR creates a folder directly in the repository named "vlang", rather than placing it in the folder packages.

robertkirkman avatar Oct 28 '25 21:10 robertkirkman

This PR seems close to actually being a merge-able build script for vlang.

Unfortunately, not quite yet - if you look closely, you can see that this PR creates a folder directly in the repository named "vlang", rather than placing it in the folder packages.

I wrote that review immediately after approving the CI runs, so I didn't see their status yet and then I was very surprised to see them "pass".

TomJo2000 avatar Oct 28 '25 21:10 TomJo2000