re-enable alacritty copy/paste
- Previously, copy/paste was disabled on Android using a patch (which i suspect is linked to a @TERMUX_PREFIX@ interpolation bug i also addressed)
- I adapted that logic and upstreamed it to
copypasta, so clipboard support now works properly on Termux.
@licy183 i'm not sure if you meant to drop the whole cargo vendor route, or just the blanket vendored-sources; It seems to be working fine without it.
@licy183 @TomJo2000 any other feedback on this?
If this is ready, could the commit history be squashed so that there are fewer small commits with short descriptions, and instead one to three large commits with all the changes made by each one listed?
Each commit should contain fix(x11/alacritty): at the beginning of the description, and then have an explanation of what it changes inside alacritty.
If you like to preserve the commit history of the branch for your own development purpose, you can feel free to close this and copy and paste everything into a separate branch, then make a new PR with a single commit.
We can also merge with a squash, though we usually prefer merge via rebase, that way the PR branch matches exactly what gets put onto master.
In upstream of the crate rustix, I have noticed that official Android support which is hardcoded with the intention of building an APK and not for Termux has been added, and because it edits the Cargo.toml in a way that removes linux-raw-sys for Android targets, it will be required to use a cargo vendor or __cargo_fetch_dep_source* crate patching method instead of the current cargo fetch --target crate patching method (which as some might be familiar, is not capable of patching Cargo.toml files, while cargo vendor and __cargo_fetch_dep_source* methods are)
https://github.com/bytecodealliance/rustix/commit/fda7cbe6b8c6ebcfd18652ca1ca3e8177f9e0d6a#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L48
This PR appears to be where alacritty is already being changed to entirely cargo vendor methods, so the inevitable necessary patch for rustix 1.1.1's Cargo.toml will belong with this PR, I thought I should mention that here in case it is helpful to know that when this is continued.
@TomJo2000 @robertkirkman squashed the commit
I'm not sure what went wrong with the linter here. I'll take a look at it when I have time to.