termux-packages icon indicating copy to clipboard operation
termux-packages copied to clipboard

scripts: changing glibc-based package name checking

Open Maxython opened this issue 1 year ago • 1 comments

A package with the glibc32 prefix in its name is a package that is compiled on a 32-bit architecture standard but will run on a 64-bit device

Maxython avatar Jul 15 '24 17:07 Maxython

The branch has conflicts.

twaik avatar Oct 19 '24 05:10 twaik

Test build - https://github.com/termux-pacman/glibc-packages/pull/317

Maxython avatar Dec 31 '24 07:12 Maxython

improved cross compilation based on bionic library

Maxython avatar Jan 24 '25 13:01 Maxython

Will requires changes to variables, will do them myself soon.

agnostic-apollo avatar Apr 14 '25 19:04 agnostic-apollo

I have overridden your latest push as I told you about and based the changes on https://github.com/termux/termux-packages/commit/eca927c1. I have removed properties.sh changes from dd07fbbb and added them in fbe83a5b.

  • You had removed the original TERMUX__PREFIX__LIB_DIR and replaced it with TERMUX_PREFIX_LIB, I have restored it back.
  • I have removed the newly added and immediately deprecated variables TERMUX_PREFIX_BASE_LIB, TERMUX_PREFIX_MULTI_LIB and TERMUX_PREFIX_GLIBC. Do not add duplicate variables.
  • I have added TERMUX__PREFIX__INCLUDE_DIR, TERMUX__PREFIX__BASE_INCLUDE_DIR and TERMUX__PREFIX__MULTI_INCLUDE_DIR, as include32 was hardcoded before.
  • I have overridden TERMUX__PREFIX as well instead of just TERMUX_PREFIX, when you override it with TERMUX__PREFIX_GLIBC. The original value for prefix is stored in TERMUX__PREFIX_CLASSICAL.
  • Removed the indented variables from properties.sh as would mess with bash language server variable definition goto's.
  • Added validation for TERMUX__PREFIX_GLIBC, and in termux_build_props__set_termux_prefix_dir_and_sub_variables() when TERMUX__PREFIX is overridden as unsafe values can have dangerous consequences.

I can squash fbe83a5b when you have reviewed and tested the changes. I have not reviewed other parts of the code, that should be done by packages devs as I don't have time.

agnostic-apollo avatar May 03 '25 08:05 agnostic-apollo