termux-packages icon indicating copy to clipboard operation
termux-packages copied to clipboard

chore(scripts/lint-packages): add HPND as allowed license

Open TomJo2000 opened this issue 1 year ago • 5 comments

We have a lot of packages using the HPND license. Currently they are all using custom for it, this PR adds HPND as an accepted license in the package build linter, and updates all applicable packages TERMUX_PKG_LICENSE field.

This shouldn't necessitate package rebuilds. If I'm wrong about that, please tell me and I'll split the PR into multiple commits for batching.

Linter checks were run locally, and all pass.

image

TomJo2000 avatar Jul 15 '24 02:07 TomJo2000

Thanks! Please add HPND to list of licenses in termux_step_install_license.sh as well. This should remove the need to specify TERMUX_PKG_LICENSE_FILE for some of the packages.

Grimler91 avatar Jul 15 '24 08:07 Grimler91

Derp, missed that one.

TomJo2000 avatar Jul 15 '24 08:07 TomJo2000

Just had a read, I think some more extensive refactoring might be in order for that one. It's currently a very awkward mix of POSIX-isms and Bash specific features as core parts of the script. I'll see if it fits within this PR or warrants its own.

TomJo2000 avatar Jul 15 '24 08:07 TomJo2000

Yeah, indeed, large parts of our scripts could benefit from some improvements :) IMO it could be a separate PR.

Grimler91 avatar Jul 15 '24 12:07 Grimler91

I am gonna split out the termux_step_install_license changes into a separate PR since I more or less rewrote the whole script.

Currently doing regression testing locally.

TomJo2000 avatar Jul 15 '24 19:07 TomJo2000

Yeah, indeed, large parts of our scripts could benefit from some improvements :) IMO it could be a separate PR.

  • #20867

Is now merged, so this PR can move ahead. If there's no other comments I'd like to merge this in ~4 hours.

TomJo2000 avatar Jul 16 '24 09:07 TomJo2000

I decided this should probably be split into 2 commits.

TomJo2000 avatar Jul 16 '24 10:07 TomJo2000