termux-packages icon indicating copy to clipboard operation
termux-packages copied to clipboard

bump(main/borgbackup): 1.4.0

Open TomJo2000 opened this issue 1 year ago • 1 comments

Just rewriting the patch and bumping msgpack.

Checklist

  • [x] Builds locally
  • [x] Builds on CI
  • [ ] Tested on device (Android 13, Aarch64, Fairphone 5)

also set a maintainer

TomJo2000 avatar Jul 11 '24 04:07 TomJo2000

For some reason it's no longer detecting the package name for building the pip wheel, even though I didn't touch that:

Processing /home/builder/.termux-build/borgbackup/src
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: UNKNOWN
  Building wheel for UNKNOWN (pyproject.toml) ... done
  Created wheel for UNKNOWN: filename=UNKNOWN-1.4.0-cp311-cp311-linux_aarch64.whl size=1630394 sha256=7610fc3d3f2490d0062f2656f58b39abae117a78d27e904803c0c8c4dee3e42e
  Stored in directory: /tmp/pip-ephem-wheel-cache-bs9cei9d/wheels/66/cf/eb/ac19181e9b868c0f786153d843bed4d73643af083e05d74722
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
  Attempting uninstall: UNKNOWN
    Found existing installation: UNKNOWN 1.4.0
    Not uninstalling unknown at /data/data/com.termux/files/usr/lib/python3.11/site-packages, outside environment /home/builder/.termux-build/python-crossenv-prefix-aarch64/cross
    Can't uninstall 'UNKNOWN'. No files were found to uninstall.
Successfully installed UNKNOWN-1.4.0

It should be looking like this:

Processing /home/builder/.termux-build/borgbackup/src
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: borgbackup
  Building wheel for borgbackup (pyproject.toml) ... done
  Created wheel for borgbackup: filename=borgbackup-1.2.8-cp311-cp311-linux_aarch64.whl size=1990948 sha256=acae6379f8d301a371a185d420e006efaa14c79f131da2733dbfa87c51904b28
  Stored in directory: /tmp/pip-ephem-wheel-cache-4kou39ru/wheels/66/cf/eb/ac19181e9b868c0f786153d843bed4d73643af083e05d74722
Successfully built borgbackup
Installing collected packages: borgbackup
Successfully installed borgbackup-1.2.8

TomJo2000 avatar Jul 11 '24 07:07 TomJo2000

Thanks licy. I hadn't gotten around to fixing this PR.

TomJo2000 avatar Jul 18 '24 03:07 TomJo2000

I'll look this over and will probably do at least one more force push to this branch before merging. Please remember to use git push --force-with-lease={{branchname}} if you intend to do more changes to this PR.

TomJo2000 avatar Jul 18 '24 03:07 TomJo2000

I wanted to turn this guard statement into a easily reusable block, for any other Python package that may benefit from it. https://github.com/termux/termux-packages/blob/4be578eb559c869e5ffa8c78caf4f2e40963b334/packages/borgbackup/build.sh#L17-L20

TomJo2000 avatar Jul 18 '24 03:07 TomJo2000