termux-packages icon indicating copy to clipboard operation
termux-packages copied to clipboard

mpd: add pulseaudio output to the default config

Open alive4ever opened this issue 2 years ago • 5 comments

Since mpd depends on pulseaudio, add the possibility to use pulseaudio output. Disabled by default.

alive4ever avatar Aug 24 '22 04:08 alive4ever

Please bump REVISION .

Done.

alive4ever avatar Aug 24 '22 04:08 alive4ever

https://github.com/MusicPlayerDaemon/MPD/blob/v0.23.9/doc/mpdconf.example#L290

tomty89 avatar Aug 24 '22 05:08 tomty89

I don't understand. What's the point of this PR / uncommenting the lines and add enabled no?

tomty89 avatar Aug 27 '22 08:08 tomty89

I don't understand. What's the point of this PR / uncommenting the lines and add enabled no?

Let's take a look at the currently shipped default mpd configuration.

$ sed '/^#/d;/^$/d' < $PREFIX/etc/mpd.conf
music_directory		"/sdcard/Music"
playlist_directory		"~/.mpd/playlists"
db_file			"~/.mpd/database"
log_file			"~/.mpd/log"
pid_file			"~/.mpd/pid"
state_file			"~/.mpd/state"
sticker_file			"~/.mpd/sticker.sql"
bind_to_address		"/data/data/com.termux/files/usr/var/run/mpd.socket"
follow_outside_symlinks	"yes"
follow_inside_symlinks		"yes"
input {
        plugin "curl"
}
audio_output {
        type            "sles"
        name            "OpenSLES output"
        mixer_type      "software"
}
audio_output {
	type		"openal"
	name		"OpenAL output"
	mixer_type	"software"
	device		"OpenSL"
	enabled		"no"
}
audio_output {
        type            "fifo"
        name            "ncmpcpp visualizer"
        path            "/data/data/com.termux/files/usr/var/run/mpd.fifo"
        format          "44100:16:2"
	enabled		"no"
}

There are three outputs: sles, openal, and fifo.

The three outputs listed on the default configuration can be easily enabled, i.e. by opening ncmpcpp and pressing 7 to go to Outputs window. The output shown on the ncmpcpp can be toggled by pressing Enter.

Screenshot_20220828-162916

This pull-request proposes the addition of pulse output to be listed on the outputs sections of ncmpcpp or other mpd clients, so users can enable pulse output without the hassle of editing $PREFIX/etc/mpd.conf just like the way openal output is listed on the default configuration.

alive4ever avatar Aug 28 '22 09:08 alive4ever

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 15 '22 16:11 stale[bot]