termux
libarrow-cpp: enable dataset and parquet features
@2096779623 it hasn't been released yet, it's still the dev version
Or at least it's listed in the docs as the dev version 🤔
Edit: yep, latest: https://arrow.apache.org/release/
I suppose it's fine. They don't even have 7.0.1 and 8.0.1 updated on their website.
Btw in case you are not aware of it, revision should be (re)set to 0 (instead of 1) for new release. (There's some ongoing discussion on whether the line should be removed in case of 0, I suppose either way is fine for now.) I missed it when I had your commit merged.
I suppose it's fine. They don't even have 7.0.1 and 8.0.1 updated on their website.
Btw in case you are not aware of it, revision should be (re)set to
0(instead of1) for new release. (There's some ongoing discussion on whether the line should be removed in case of0, I suppose either way is fine for now.) I missed it when I had your commit merged.
I assume you mean in my previous PR?
@2096779623 @tomty89 was there something you wanted changed before you merged this?
@2096779623 @tomty89 was there something you wanted changed before you merged this?
LGTM, thanks!
Isn't dataset enabled by default though? (It doesn't hurt much to set the option explicitly, but I'd prefer not to myself.)
Isn't dataset enabled by default though? (It doesn't hurt much to set the option explicitly, but I'd prefer not to myself.)
I can check, but the reason I submitted this pr was that it was missing from the Python bindings
Are you talking about the cpython so that are not being built when you install pyarrow with pip?
AFAICT, the current libarrow-cpp package is built with dataset enabled (but not parquet), and if you set PYARROW_WITH_DATASET=1 when you install pyarrow, you'll see that the missing parquet is the road blocker.
Arrow version 9.0.0 has been released since I opened this pr, so I've updated that, and removed the dataset flag
I suppose it's fine. They don't even have 7.0.1 and 8.0.1 updated on their website.
Btw in case you are not aware of it, revision should be (re)set to
0(instead of1) for new release. (There's some ongoing discussion on whether the line should be removed in case of0, I suppose either way is fine for now.) I missed it when I had your commit merged.
Looks like the linter forbids this?
Yeah. Apparently you should remove or comment the line. I recommend the latter with the value set to 1 to make it convenient for the next rev bump.
And should probably change linter to allow TERMUX_PKG_REVISION=0, looks better than having a commented line IMO