termux-app icon indicating copy to clipboard operation
termux-app copied to clipboard

Fixed: Make ScrollDown escape respect margins

Open evg-zhabotinsky opened this issue 2 years ago • 4 comments

SD sequence (${CSI}${N}T) was scrolling the whole width of the terminal instead of just between the margins. RI sequence (${ESC}M, move cursor up 1 line) was doing the same. Fixed that.

Fixes #2576 where in tmux scrolling one of several side-by-side panels down resulted in all visually scrolling.

evg-zhabotinsky avatar Sep 25 '22 05:09 evg-zhabotinsky

@Fparisa166 You can install an .apk found under "checks" below. ("Details" link next to "build", then click "Summary" and under "Artifacts" find a file that matches your phone, probably termux-app_*-android-7-github-debug_universal, it's a zip with .apk inside.) This requires tha Termux.Api and others, if any, are also installed from Github releases.

Or just wait until an official update to Termux.

evg-zhabotinsky avatar Sep 30 '22 09:09 evg-zhabotinsky

Just poking, this PR hasn't been merged for over 3 months. The changes seem trivial enough to verify, and they fix an actual problem. (See the referenced issue.) Also, I've been using Termux with this patch semi-frequently all that time, didn't notice any issues. Or do I need to create a new issue, because the one this PR references was (mistakenly) closed as a wontfix?

evg-zhabotinsky avatar Jan 05 '23 20:01 evg-zhabotinsky

@evg-zhabotinsky I am guessing @agnostic-apollo has already merged this locally and will push it as part of the upcoming 0.119 update, considering the force-pushes above

Grimler91 avatar Jan 06 '23 10:01 Grimler91

The force push was for master branch, but this pull should be mergable before next release, haven't tested it yet, will do it after I push my local changes.

agnostic-apollo avatar Jan 06 '23 10:01 agnostic-apollo