glibc-packages icon indicating copy to clipboard operation
glibc-packages copied to clipboard

[Bug]: Buffer overflow in __is_mmaped (glibc patches), and other problems

Open Kamillaova opened this issue 4 months ago • 9 comments

Problem description

I'm sleepy now, so I don't want to write any explanations here, sorry. But I think you'll understand without explanations, thanks. UPD okay I essentially wrote it for other problems.

https://github.com/termux-pacman/glibc-packages/blob/63d5639e392fe3c6cdc16391ccc8845f32e1ef13/gpkg/glibc/mprotect.c#L53

Also:

  • glibc supports compiling with -Werror=no-unused-variable, but it was broken here: https://github.com/termux-pacman/glibc-packages/blob/63d5639e392fe3c6cdc16391ccc8845f32e1ef13/gpkg/glibc/setegid.c.patch#L13
  • glibc supports compiling with -Werror=maybe-uninitialized, but it was broken here (since r is not probably not initialized, and I don't quite understand what value r should have): https://github.com/termux-pacman/glibc-packages/blob/63d5639e392fe3c6cdc16391ccc8845f32e1ef13/gpkg/glibc/clock_gettime.c.patch#L7
  • https://github.com/termux-pacman/glibc-packages/issues/292#issuecomment-2381080824

And... for the future: please create all patches with the -p flag, for better navigation through patches. -p, --show-c-function show which C function each change is in

Kamillaova avatar Sep 29 '24 02:09 Kamillaova