resource-loader icon indicating copy to clipboard operation
resource-loader copied to clipboard

Published 20 hours ago • verified publisher icon terl

Fix isJarFile method for paths with spaces

Open tyilo opened this issue 2 years ago • 5 comments

Without this loading bundled the bundled libsodium using lazy-sodium will fail, if the jar is in a directory containing spaces.

tyilo avatar Sep 09 '21 13:09 tyilo

Hi @Tyilo,

Many thanks for your first contribution.

It seems this fix https://github.com/terl/resource-loader/pull/12 has caused some conflicts on your PR. Can you verify if that fix fixes your bug?

gurpreet- avatar Dec 23 '21 00:12 gurpreet-

Unfortunately I can confirm that the bug is still present in version 2.0.2. I will update the merge request.

tyilo avatar Jan 03 '22 14:01 tyilo

@gurpreet- It now works again and I've also added a test.

tyilo avatar Jan 03 '22 15:01 tyilo

@gurpreet- Can you merge this?

tyilo avatar Jul 19 '22 14:07 tyilo

@gurpreet- Ping

tyilo avatar Nov 06 '23 09:11 tyilo