MANIFEST header wrong

[vogella]

I think the import for org.slj4j in your MANIFEST.MF is wrong. Is this really required?

Manifest-Version: 1.0 Bnd-LastModified: 1617569345955 Bundle-ManifestVersion: 2 Bundle-Name: resource-loader Bundle-SymbolicName: resource-loader Bundle-Version: 2.0.1 Created-By: 1.8.0_172 (Oracle Corporation) Import-Package: com.sun.jna;version="[5.5,6)",org.slf4j;version="[2.0, 3)" Main-Class: com.goterl.resourceloader.Main Private-Package: com.goterl.resourceloader Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))" Tool: Bnd-5.4.0.202103312110-SNAPSHOT

[414n]

Also, the com.goterl.resourceloader package should probably be under Export-Package instead of Private-Package, as the lazysodium-java bundle imports it...

[gurpreet-]

I guess this is related to OSGI/bnd. I have no experience with it but I hope this commit fixes it

https://github.com/terl/resource-loader/commit/5bd12afc929fc2c911b11c8632142c608f0254fc

I admit, I do need some help on this! Any help is appreciated 😄

[414n]

This is what I see comparing the manifest from the previous 2.0.1 to 2.0.2, where 5bd12af got applied:

--- manifest-2.0.1.txt  2022-01-07 23:22:25.263238259 +0100
+++ manifest-2.0.2.txt  2022-01-07 23:21:53.488236858 +0100
@@ -1,13 +1,13 @@
 Manifest-Version: 1.0
-Bnd-LastModified: 1617569345955
+Bnd-LastModified: 1640354069571
 Bundle-ManifestVersion: 2
 Bundle-Name: resource-loader
 Bundle-SymbolicName: resource-loader
-Bundle-Version: 2.0.1
+Bundle-Version: 2.0.2
 Created-By: 1.8.0_172 (Oracle Corporation)
-Import-Package: com.sun.jna;version="[5.5,6)",org.slf4j;version="[2.0,
+Export-Package: com.goterl.resourceloader;version="2.0.2"
+Import-Package: com.sun.jna;version="[5.9,6)",org.slf4j;version="[2.0,
  3)"
 Main-Class: com.goterl.resourceloader.Main
-Private-Package: com.goterl.resourceloader
 Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
-Tool: Bnd-5.4.0.202103312110-SNAPSHOT
+Tool: Bnd-6.2.0.202112231652-SNAPSHOT

From the looks of it, the issue of the com.goterl.resourceloader package that should've been exported is solved.

I don't know if @vogella concerns regarding the slf4j dependency are still an issue, though.