jna 5.17.0 Incompatibility with lazysodium-java 5.2.0

[ParaskP7]

Hi team, in this woocommerce-android open-source project of ours, which is using this EncryptedLogging open-source library of ours, after updating jna to 5.17.0 and lazysodium-android to 5.2.0 to get that library 16 KB page size compatible (see libs.versions.toml), we are now getting the below crashes:

Structure.getFieldOrder() on class com.goterl.lazysodium.interfaces.SecretStream$State$ByReference
returns names ([_pad, k, nonce]) which do not match declared field names ([_pad, k])

and/or...

Structure.getFieldOrder() on class com.goterl.lazysodium.interfaces.SecretStream$State$ByReference
returns names ([_pad, k, nonce]) which do not match declared field names ([_pad, nonce])

...plus other combinations like that, ie [_pad], [k, nonce], versus [_pad, k, nonce], although less frequent... 🤔

It seems that lazysodium-java 5.2.0's SecretStream$State$ByReference structure declares fields [_pad, k, nonce] but jna 5.17.0 only recognizes [_pad, k] and/or [_pad, nonce] due to changes in how jna handles Structure field declarations.

Any ideas on that? 🤔

Many thanks for helping out! 🙏

[angusholder]

Have you recently turned on R8 minification for your app? I got errors similar to that due to R8 optimizing out parts of JNA (which lazysodium is built on), and I fixed it by adding the proguard rules that JNA suggest here https://github.com/java-native-access/jna/blob/master/www/FrequentlyAskedQuestions.md#jna-on-android

[ParaskP7]

Thanks for the reply @angusholder , much appreciated! 🙇

Have you recently turned on R8 minification for your app?

Unfortunately, this is not it, woocommerce-android been having minifyEnabled = true for years now. 🤷

I got errors similar to that due to R8 optimizing out parts of JNA (which lazysodium is built on)...

👍

...and I fixed it by adding the proguard rules that JNA suggest here https://github.com/java-native-access/jna/blob/master/www/FrequentlyAskedQuestions.md#jna-on-android

Unfortunately, this too is not it, on this EncryptedLogging library of ours, which is the library using JNA, we do have such consumer-rules.pro ProGuard rules: 🤔

consumer-rules.pro

# https://github.com/java-native-access/jna/blob/master/www/FrequentlyAskedQuestions.md#jna-on-android
-dontwarn java.awt.*
-keep class com.sun.jna.* { *; }
-keepclassmembers class * extends com.sun.jna.* { public *; }