Dennis Terhorst

Results 97 comments of Dennis Terhorst

This seems good to go once the break is reverted. With the commit https://github.com/nest/nest-simulator/pull/3257/commits/243449d35f5c154a90fcf54e5441380d94d34a94 correctly being flagged broken by the CI: ``` Error: /home/runner/work/nest-simulator/nest-simulator/libnestutil/iterator_pair.h:26:10: fatal error: boost/iterator/iterator_adaptor.hpp: No such file...

Improved CI runs additionally revealed a spurious call to `mpirun` in case of `-Dwith-mpi=OFF` somewhere in the pytest suite (now becoming visible since mpi is not installed anymore on the...

@gtrensch, the original boost issue is now proven to be caught. I updated the description above. The two commits also show again, that multiple `#ifdef` may hide the bug from...

Wow, thanks @gtrensch for fixing this :clap: I agree too your comment that most of the `try…except…if…` parts are problematic. I would have expected the `@unittest.skipIf(not HAVE_MPI, "NEST was compiled...

I cannot assign myself as reviewer, but agree :+1: to your changes to fix the downstream matter. They are quite orthogonal, so @gtrensch, for the remaining changes should be unproblematic...

Thanks for the very enlightening process and inspiring reviews :+1:

Could you please provide a short description for this PR?

@muffgaga , this seems to be basically complete except for the suggested change. Could you also add a *description* to this PR? The current sentence seems to have little relation...

@muffgaga, could you re-trigger the CI? I don't have the buttons in this PR. Either Github removed them, the force-push broke something, or you have some settings in your branch...

Hi @otcathatsya, what's your status on this?