line-charts icon indicating copy to clipboard operation
line-charts copied to clipboard

HoverMany and Hover don't actually hover

Open Munksgaard opened this issue 6 years ago • 6 comments

Ellie link

I've tried to port the first example from the old version to 0.19, but the hoverMany function seems to work differently from what it did back then. I would expect hoverMany to create a little box next to the cursor or the actual point in question, but instead it seems like a box is added at the bottom of the chart. The same happens if I try to use hover

Am I missing something?

Munksgaard avatar Nov 21 '18 12:11 Munksgaard

Apparently a typo (created during migration to 0.19?) introduced on Oct 27, 2018

https://github.com/terezka/line-charts/commit/a92d43dedb623823fe09d8cdfe26ce016b30d867#r31813341

yuzisee avatar Jan 01 '19 19:01 yuzisee

Certainly looks like it.

Munksgaard avatar Jan 01 '19 22:01 Munksgaard

Hi, is there any hope that this would be fixed in near future?

jartsap avatar Feb 26 '19 12:02 jartsap

I believe this is fixed by #58, which was merged recently, but there isn't a new version on https://package.elm-lang.org yet.

LiberalArtist avatar Aug 05 '19 23:08 LiberalArtist

I can confirm that I am still getting this error in 2.0.0 (the current version on package.elm-lang.org) and it's causing me a lot of trouble.

Is there any chance of getting a new package version with this fix?

QuinnFreedman avatar Sep 19 '19 17:09 QuinnFreedman

I've vendored this package in as a Git submodule to get the fix from #58, and I can report that it's working great for us.

LiberalArtist avatar Dec 15 '19 21:12 LiberalArtist