sco.js icon indicating copy to clipboard operation
sco.js copied to clipboard

Introduces granular setting to countdown

Open jperkelens opened this issue 11 years ago • 5 comments

Hi! Nice job with these plugins. I've added a 'granular' option to the countdown, which stops the string calculation at hours if there is more than a day left, and will only run the code to update on the hour change.

This can obviously be extended for any level of granularity and I'm happy to do so if you feel its a good idea.

jperkelens avatar Aug 20 '13 14:08 jperkelens

This is a nice idea...how about instead of granularity: true/false you create a granularity: d/h/m/s?

terebentina avatar Aug 20 '13 15:08 terebentina

Sounds good. I'll work on it in the next day or two and amend the pull request.

Cheers.

On Tue, Aug 20, 2013 at 11:07 AM, Dan Caragea [email protected]:

This is a nice idea...how about instead of granularity: true/false you create a granularity: d/h/m/s?

— Reply to this email directly or view it on GitHubhttps://github.com/terebentina/sco.js/pull/15#issuecomment-22951751 .

jperkelens avatar Aug 20 '13 20:08 jperkelens

Created the setting as you requested. Give it a spin, lemme know what you think.

jperkelens avatar Aug 24 '13 14:08 jperkelens

Hi again, any chance you'll pull this in soon?

jperkelens avatar Aug 28 '13 17:08 jperkelens

Yup, tomorrow will do

terebentina avatar Aug 28 '13 20:08 terebentina