react-popover icon indicating copy to clipboard operation
react-popover copied to clipboard

Failed prop type: Calling PropTypes validators directly is not supported by the 'prop-types' package. Use PropTypes.checkPropTypes()

Open stahlmanDesign opened this issue 7 years ago • 5 comments

I was trying to fix this but when I look at the code I don't see why it's showing the deprecation warning. I read https://facebook.github.io/react/warnings/dont-call-proptypes.html#fixing-the-false-positive-in-third-party-proptypes about the message possibly being a false-positive, but don't know if that's the case here.

stahlmanDesign avatar Aug 10 '17 04:08 stahlmanDesign

OK, I investigated this some more, and I found that the npm distribution is inlining prop-types into the module source code. This inlined version of prop-types always prints that error. So, there's something wrong with the build configuration of this package, it should not provide its own prop-types module, it should use the same one the rest of the application is using.

dobesv avatar Nov 02 '17 16:11 dobesv

I will try to have a look this weekend - making it work with react 16 should fix the problem.

terebentina avatar Nov 02 '17 16:11 terebentina

It should probably be deployed with a dependency or peer dependency on prop-types and not embed prop-types into the js file.

dobesv avatar Nov 02 '17 17:11 dobesv

What is the status of this issue?

geocine avatar Mar 01 '19 16:03 geocine

Did you do it @terebentina ? Does not work on React 16

pedroBruno7 avatar Apr 23 '19 16:04 pedroBruno7