Wilmer Arambula

Results 115 comments of Wilmer Arambula

> > > ![Снимок экрана от 2024-10-01 16-30-24](https://private-user-images.githubusercontent.com/90403480/372488536-e0c155f9-c869-4dcb-8664-0d16410f8946.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjc4NTM4OTAsIm5iZiI6MTcyNzg1MzU5MCwicGF0aCI6Ii85MDQwMzQ4MC8zNzI0ODg1MzYtZTBjMTU1ZjktYzg2OS00ZGNiLTg2NjQtMGQxNjQxMGY4OTQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDAyVDA3MTk1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM5ODAxZTEzNTUzODFiMTViNWI2ZWE3ZTYzZTUwNDQ4ZmJmYWNmNjBkMTgxNGY2ZDRlYzg5OTA2ZWZlZTRkNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wKWGjSB2B2sbg0lOrpMam_swZybx7zbjyZkd_mTPy6I) > > > That my pslam error > > > > > > It looks like you either have a different version...

What is missing to finish the PR?

I'm thinking of merging this PR into a develop branch, so that the missing stuff can be addressed, do you agree?

> > I'm thinking of merging this PR into a develop branch, so that the missing stuff can be addressed, do you agree? > > Yes. Two things I don't...

If it makes sense, in this case i think it would be better to create a new component, `Menu::widget`, that is responsible for generating all the navigation for all the...

If that's what i mean, could you give me an example of what the syntax would be, to make it clearer?

What if we create a class to generate the navigation items, and we could pass a varadic, or an array that in turn creates the item generation widget, we would...

It could be something like this. ```php NavBar::widget() ->menu( Menu::widget() ->currentPath('/home') ->id('menu_1') ->items( Item::widget()->label('Home')->link('/home'), Item::widget()->label('Link')->link('/link'), Item::widget()->label('Disable')->link('/disable')->disable(), ) ) ->render(); ```

I'll help with the review, we're going to refactor all the widgets, but let's work on them one at a time, okay?