Selenium-Remote-Driver icon indicating copy to clipboard operation
Selenium-Remote-Driver copied to clipboard

Fix the action type for button_up()

Open bschmalhofer opened this issue 4 years ago • 1 comments

I have been looking at DragAndDrop failures of the Selenium tests for OTOBO. There I noticed that pointerDown was emitted twice. I think that the WebDriver action should be pointerUp instead of pointerDown for the sub button_up().

bschmalhofer avatar Jan 16 '21 11:01 bschmalhofer

Coverage Status

Coverage decreased (-0.05%) to 62.052% when pulling 177a44dc1503b95f5325e5d5f8e38f5098f5595e on bschmalhofer:bschmalhofer-patch-1 into c0f15edc41f7178f8fc531c3a02cf47c6faa3f39 on teodesian:master.

coveralls avatar Jan 16 '21 11:01 coveralls

I still think the the method button_up() should be fixed. I updated the PR, making sure it still applies to the current HEAD of master.

bschmalhofer avatar Apr 06 '23 13:04 bschmalhofer

Should be in 1.49, just uploaded to CPAN

teodesian avatar Apr 06 '23 14:04 teodesian

Thanks a bunch. I updated my required version of Selenium::Remote::Driver and closed https://github.com/RotherOSS/otobo/issues/727 .

bschmalhofer avatar Apr 06 '23 18:04 bschmalhofer